fix: use HTTPS for cpanminus download in CI#2050
Merged
Conversation
Switch curl from http:// to https:// when downloading cpanminus to prevent MITM attacks. Also add -fsSL flags for fail-fast on HTTP errors and silent progress. Fixes #2049 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zack Koppert <zkoppert@github.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the CI workflow by switching the cpanminus bootstrap download from HTTP to HTTPS, reducing exposure to MITM attacks during dependency installation.
Changes:
- Update the cpanminus install command in CI to use
https://cpanmin.us. - Make
curlfail on HTTP errors and reduce noisy output via-fsSL.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Switches cpanminus download to HTTPS with safer curl flags during CI Perl dependency setup. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the cpanminus download in CI from plain HTTP to HTTPS, closing a MITM attack vector.
Fixes #2049
Changes
.github/workflows/ci.yml:51:curl -L http://cpanmin.us→curl -fsSL https://cpanmin.ushttps://prevents network attackers from injecting malicious code-ffails fast on HTTP errors instead of piping error pages to perl-sSsuppresses progress but shows errorsTesting